[
https://issues.apache.org/jira/browse/BEAM-13685?focusedWorklogId=712410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712410
]
ASF GitHub Bot logged work on BEAM-13685:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 21:22
Start Date: 20/Jan/22 21:22
Worklog Time Spent: 10m
Work Description: VictorPlusC commented on a change in pull request
#16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r789160242
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -359,10 +359,14 @@ def get_cache_manager(self, pipeline,
create_if_absent=False):
manager for the pipeline."""
cache_manager = self._cache_managers.get(str(id(pipeline)), None)
if not cache_manager and create_if_absent:
- cache_dir = tempfile.mkdtemp(
- suffix=str(id(pipeline)),
- prefix='it-',
- dir=os.environ.get('TEST_TMPDIR', None))
+ from apache_beam.runners.interactive import interactive_beam as ib
+ if ib.options.specified_cache_dir:
+ cache_dir = ib.options.specified_cache_dir
Review comment:
Noted this suggestion down in our design doc, will be adding this logic
with the GCS support in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 712410)
Time Spent: 7.5h (was: 7h 20m)
> Enable users to specify cache directory under Interactive Beam options
> ----------------------------------------------------------------------
>
> Key: BEAM-13685
> URL: https://issues.apache.org/jira/browse/BEAM-13685
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> - Adds specified_cache_dir option under interactive_beam.py and
> interactive_options.py
> - Integrates new specified_cache_dir from interactive_beam.py into
> cache_manager.py and streaming_cache.py
> - Includes unit tests under cache_manager_test.py and streaming_cache_test.py
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
