[
https://issues.apache.org/jira/browse/BEAM-13685?focusedWorklogId=712441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712441
]
ASF GitHub Bot logged work on BEAM-13685:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 22:18
Start Date: 20/Jan/22 22:18
Worklog Time Spent: 10m
Work Description: VictorPlusC commented on a change in pull request
#16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r789193519
##########
File path: sdks/python/apache_beam/runners/interactive/cache_manager_test.py
##########
@@ -215,6 +215,21 @@ def test_load_saved_pcoder(self):
type(self.cache_manager.load_pcoder('full', 'a key')),
type(coders.registry.get_coder(int)))
+ def test_cache_manager_uses_ib_specified_cache_dir(self):
Review comment:
I've added two additional tests:
- test under cache_manager_test.py that:
- writes some values to a cache with default settings
- writes the same values to a cache with ib.options.cache_root
- asserts that both caches contain the same contents
- test under streaming_cache_test.py that:
- writes some values to a cache with default settings
- writes the same values to a cache with ib.options.cache_root
- asserts that both caches contain the same contents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 712441)
Time Spent: 8h (was: 7h 50m)
> Enable users to specify cache directory under Interactive Beam options
> ----------------------------------------------------------------------
>
> Key: BEAM-13685
> URL: https://issues.apache.org/jira/browse/BEAM-13685
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 8h
> Remaining Estimate: 0h
>
> - Adds specified_cache_dir option under interactive_beam.py and
> interactive_options.py
> - Integrates new specified_cache_dir from interactive_beam.py into
> cache_manager.py and streaming_cache.py
> - Includes unit tests under cache_manager_test.py and streaming_cache_test.py
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
