[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=717380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717380
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/22 23:50
Start Date: 28/Jan/22 23:50
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #16154:
URL: https://github.com/apache/beam/pull/16154#discussion_r794958981
##########
File path: sdks/python/apache_beam/examples/complete/game/user_score_test.py
##########
@@ -42,7 +40,6 @@ class UserScoreTest(unittest.TestCase):
'user1_team1,team1,14,1447697463000,2015-11-16 18:11:03.955',
]
- @pytest.mark.examples_postcommit
Review comment:
I added this mark on a previous PR for the same ticket, but this test
https://github.com/apache/beam/blob/aefdc89b927a9e7099fd4a2cc4080babf4ec9790/sdks/python/apache_beam/examples/complete/game/user_score_test.py#L43
was testing only a transform instead of the full pipeline of the example, I
created a new test
https://github.com/apache/beam/blob/aefdc89b927a9e7099fd4a2cc4080babf4ec9790/sdks/python/apache_beam/examples/complete/game/user_score_it_test.py#L89.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717380)
Time Spent: 33.5h (was: 33h 20m)
> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 33.5h
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
