[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=717395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717395
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/22 00:02
Start Date: 29/Jan/22 00:02
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #16154:
URL: https://github.com/apache/beam/pull/16154#discussion_r794961792
##########
File path: sdks/python/apache_beam/examples/complete/autocomplete.py
##########
@@ -40,7 +40,7 @@ def run(argv=None):
# We use the save_main_session option because one or more DoFn's in this
# workflow rely on global context (e.g., a module imported at module level).
pipeline_options = PipelineOptions(pipeline_args)
- pipeline_options.view_as(SetupOptions).save_main_session = True
+ pipeline_options.view_as(SetupOptions).save_main_session = save_main_session
Review comment:
I think when I tried the example on a regular direct runner, there were
also no issues. If that's the case, could you please check if we could instead
remove the `--save_main_session=True` from `options` within test_direct_runner
instead of having to add `--save_main_session=False` into the
tests+parameterize the examples with this param?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717395)
Time Spent: 34h 20m (was: 34h 10m)
> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 34h 20m
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
