[ 
https://issues.apache.org/jira/browse/BEAM-13430?focusedWorklogId=718270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718270
 ]

ASF GitHub Bot logged work on BEAM-13430:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Jan/22 22:25
            Start Date: 31/Jan/22 22:25
    Worklog Time Spent: 10m 
      Work Description: emilymye commented on a change in pull request #16675:
URL: https://github.com/apache/beam/pull/16675#discussion_r796114747



##########
File path: runners/spark/spark_runner.gradle
##########
@@ -165,12 +165,12 @@ dependencies {
   implementation library.java.vendored_grpc_1_43_2
   implementation library.java.vendored_guava_26_0_jre
   implementation "com.codahale.metrics:metrics-core:3.0.1"
-  implementation 
"org.apache.spark:spark-core_$spark_scala_version:$spark_version"
-  implementation 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
+  provided "org.apache.spark:spark-core_$spark_scala_version:$spark_version"
+  provided 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
   permitUnusedDeclared 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"

Review comment:
       I ran into some issues with this with other provided deps :/

##########
File path: runners/spark/spark_runner.gradle
##########
@@ -165,12 +165,12 @@ dependencies {
   implementation library.java.vendored_grpc_1_43_2
   implementation library.java.vendored_guava_26_0_jre
   implementation "com.codahale.metrics:metrics-core:3.0.1"
-  implementation 
"org.apache.spark:spark-core_$spark_scala_version:$spark_version"
-  implementation 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
+  provided "org.apache.spark:spark-core_$spark_scala_version:$spark_version"
+  provided 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
   permitUnusedDeclared 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"

Review comment:
       I ran into some issues with the checker for other provided deps :/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 718270)
    Time Spent: 76h 40m  (was: 76.5h)

> Upgrade Gradle version to 7.3
> -----------------------------
>
>                 Key: BEAM-13430
>                 URL: https://issues.apache.org/jira/browse/BEAM-13430
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Kiley Sok
>            Assignee: Kiley Sok
>            Priority: P1
>             Fix For: 2.36.0
>
>          Time Spent: 76h 40m
>  Remaining Estimate: 0h
>
> This is the first version to support Java 17
>  
> https://docs.gradle.org/current/userguide/compatibility.html



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to