[
https://issues.apache.org/jira/browse/BEAM-13430?focusedWorklogId=718938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718938
]
ASF GitHub Bot logged work on BEAM-13430:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 19:45
Start Date: 01/Feb/22 19:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #16688:
URL: https://github.com/apache/beam/pull/16688#discussion_r796939457
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -811,7 +811,9 @@ class BeamModulePlugin implements Plugin<Project> {
// Provided configuration to match Maven provided scope
project.configurations {
provided
- implementation.extendsFrom(provided)
+ compileOnly.extendsFrom(provided)
+ runtimeOnly.extendsFrom(provided)
+ testCompileOnly.extendsFrom(provided)
Review comment:
We shouldn't be adding to testCompileOnly.
Dependencies that are needed during test compilation should be declared
under testImplementation.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 718938)
Time Spent: 78h (was: 77h 50m)
> Upgrade Gradle version to 7.3
> -----------------------------
>
> Key: BEAM-13430
> URL: https://issues.apache.org/jira/browse/BEAM-13430
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kiley Sok
> Assignee: Kiley Sok
> Priority: P1
> Fix For: 2.36.0
>
> Time Spent: 78h
> Remaining Estimate: 0h
>
> This is the first version to support Java 17
>
> https://docs.gradle.org/current/userguide/compatibility.html
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
