[
https://issues.apache.org/jira/browse/BEAM-4032?focusedWorklogId=720975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720975
]
ASF GitHub Bot logged work on BEAM-4032:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 16:02
Start Date: 04/Feb/22 16:02
Worklog Time Spent: 10m
Work Description: AnandInguva commented on a change in pull request
#16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r799600946
##########
File path: sdks/python/container/piputil.go
##########
@@ -51,7 +51,7 @@ func pipInstallRequirements(files []string, dir, name string)
error {
// used without following their dependencies.
args := []string{"install", "-r", filepath.Join(dir,
name), "--disable-pip-version-check", "--no-index", "--no-deps",
"--find-links", dir}
if err := execx.Execute(pip, args...); err != nil {
- return err
+ fmt.Println("Requirements cache " + dir + " is empty.
Downloading packages from PyPI")
Review comment:
Added an integration test which takes a requirements file. I added numpy
as a requirement in the .txt file. I looked at the logs and we are calling `pip
download ...`. I guess that should do it.
##########
File path: sdks/python/container/piputil.go
##########
@@ -51,7 +51,7 @@ func pipInstallRequirements(files []string, dir, name string)
error {
// used without following their dependencies.
args := []string{"install", "-r", filepath.Join(dir,
name), "--disable-pip-version-check", "--no-index", "--no-deps",
"--find-links", dir}
if err := execx.Execute(pip, args...); err != nil {
- return err
+ fmt.Println("Requirements cache " + dir + " is empty.
Downloading packages from PyPI")
Review comment:
Added an integration test which takes a requirements file. I added numpy
as a requirement in the .txt file. I looked at the logs and we are calling `pip
download ...`. I think that should do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720975)
Time Spent: 16h 40m (was: 16.5h)
> Support staging binary distributions of dependency packages.
> ------------------------------------------------------------
>
> Key: BEAM-4032
> URL: https://issues.apache.org/jira/browse/BEAM-4032
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Anand Inguva
> Priority: P2
> Time Spent: 16h 40m
> Remaining Estimate: 0h
>
> requirements.txt only supports source-distribution dependencies [1].
> --extra_packages does not officially support wheel files [2].
> It is possible to expand this to support binary distributions as long as we
> have the knowledge of the target platform.
> We should take into consideration the mechanisms of staging dependencies
> through portability framework, and perhaps consolidate some of the existing
> options.
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L260]
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L188]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
