[
https://issues.apache.org/jira/browse/BEAM-4032?focusedWorklogId=722386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-722386
]
ASF GitHub Bot logged work on BEAM-4032:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 22:39
Start Date: 07/Feb/22 22:39
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r801119086
##########
File path: sdks/python/apache_beam/examples/complete/juliaset/requirements.txt
##########
@@ -0,0 +1,18 @@
+###############################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###############################################################################
+numpy
Review comment:
This example already requires numpy in
https://github.com/apache/beam/blob/16934836498bfe03cdcfb5f8b77f57c1a9bff795/sdks/python/apache_beam/examples/complete/juliaset/setup.py#L111
Given that you are modifying the example, users may be confused why numpy
needs to be specified twice: in a requirements.txt file and in setup.py.
Let's try to use a different pipeline for this test. You could create an
example where a requirements file is used, or just a test pipeline that does
something trivial, like checking whether a particular library is installed and
doesn't do any data processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 722386)
Time Spent: 18h 10m (was: 18h)
> Support staging binary distributions of dependency packages.
> ------------------------------------------------------------
>
> Key: BEAM-4032
> URL: https://issues.apache.org/jira/browse/BEAM-4032
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Anand Inguva
> Priority: P2
> Time Spent: 18h 10m
> Remaining Estimate: 0h
>
> requirements.txt only supports source-distribution dependencies [1].
> --extra_packages does not officially support wheel files [2].
> It is possible to expand this to support binary distributions as long as we
> have the knowledge of the target platform.
> We should take into consideration the mechanisms of staging dependencies
> through portability framework, and perhaps consolidate some of the existing
> options.
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L260]
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L188]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
