[
https://issues.apache.org/jira/browse/BEAM-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488348#comment-17488348
]
Danny McCormick commented on BEAM-13419:
----------------------------------------
Ok, correction on the previous comment - with the dataflow runner, it
definitely started up the tests, but the job did not correctly run and the
tests failed from a timeout after 10 minutes. I think that is probably still
fine though; I'm definitely not seeing the behavior described here in the
ticket where failing tests go unnoticed.
Sorry for the volume of messages here [~danoliveira], but if you have any
thoughts on how to repro please let me know, otherwise I'll probably resolve
this one as can't repro
> Add Go integration test errors when forgetting ptest.Main/beam.Init
> -------------------------------------------------------------------
>
> Key: BEAM-13419
> URL: https://issues.apache.org/jira/browse/BEAM-13419
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Danny McCormick
> Priority: P2
>
> Currently when someone writes an integration test and forgets to put
> ptest.Main into TestMain (or their own code calling beam.Init), then the SDK
> harness runs the tests as unit tests and ends up passing them because
> ptest.Run and beam.Run seem to just instantly pass without a problem when
> beam.Init hasn't been called.
> The end result is that SDK harnesses in this setup just instantly pass all
> the tests and then close without any error messages.
> This code path should have an error added so that if beam.Init hasn't been
> run when ptest.Run executes, then it fails with an error.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
