[ 
https://issues.apache.org/jira/browse/BEAM-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488383#comment-17488383
 ] 

Danny McCormick commented on BEAM-13419:
----------------------------------------

Well, enforcing that beam must be initialized in the dataflow runner will fix 
any possibility of an issue here, and we should do that anyways, so I'll 
resolve after [https://github.com/apache/beam/pull/16765] goes in

> Add Go integration test errors when forgetting ptest.Main/beam.Init
> -------------------------------------------------------------------
>
>                 Key: BEAM-13419
>                 URL: https://issues.apache.org/jira/browse/BEAM-13419
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Danny McCormick
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when someone writes an integration test and forgets to put 
> ptest.Main into TestMain (or their own code calling beam.Init), then the SDK 
> harness runs the tests as unit tests and ends up passing them because 
> ptest.Run and beam.Run seem to just instantly pass without a problem when 
> beam.Init hasn't been called.
> The end result is that SDK harnesses in this setup just instantly pass all 
> the tests and then close without any error messages.
> This code path should have an error added so that if beam.Init hasn't been 
> run when ptest.Run executes, then it fails with an error.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to