[
https://issues.apache.org/jira/browse/BEAM-13908?focusedWorklogId=724874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724874
]
ASF GitHub Bot logged work on BEAM-13908:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 01:07
Start Date: 11/Feb/22 01:07
Worklog Time Spent: 10m
Work Description: damccorm commented on pull request #16816:
URL: https://github.com/apache/beam/pull/16816#issuecomment-1035694510
;tldr - go ahead and merge it if you're ok with that
@lostluck thanks for the thoughts - FWIW I wasn't actually saying its the
wrong approach because we should prefer a traditional dependency injection
approach - I agree that is better in most cases (and probably support that as a
repo blanket policy, it probably helps avoid pitfalls), but I'm not sure it was
actually less clean or more brittle in that specific case.
Regardless, I'm not really interested in doing a dependency injection type
approach here so I'd just merge it. My primary reasoning for not testing that
behavior was that by mocking CommandContext (and essentially mocking
cmd.Output() by extension), I was not actually testing much - it was code
coverage for the sake of code coverage, not in order to actually ensure we're
making our code better. That would still apply with dependency injection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724874)
Time Spent: 1h 20m (was: 1h 10m)
> Increase unit testing in the gcpopts package
> --------------------------------------------
>
> Key: BEAM-13908
> URL: https://issues.apache.org/jira/browse/BEAM-13908
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Labels: starter
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [gcpopts
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/options/gcpopts]
> We want code coverage at or above 50%, it is currently at 40%.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
