[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=223019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223019
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 14:56
Start Date: 04/Apr/19 14:56
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8218: [BEAM-3545]
Support Metrics in Go SDK CombineFns
URL: https://github.com/apache/beam/pull/8218#discussion_r272221238
##########
File path: sdks/go/pkg/beam/core/runtime/exec/translate.go
##########
@@ -375,13 +375,15 @@ func (b *builder) makeLink(from string, id linkID)
(Node, error) {
switch op {
case graph.ParDo:
- n := &ParDo{UID: b.idgen.New(), PID: id.to,
Inbound: in, Out: out}
+ n := &ParDo{UID: b.idgen.New(), PID:
transform.UniqueName, Inbound: in, Out: out}
Review comment:
Correct, and while this works OK, the unique names are unambiguous, and
supposed to be required by the runner spec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223019)
Time Spent: 10h 20m (was: 10h 10m)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: portability, triaged
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
