[
https://issues.apache.org/jira/browse/BEAM-13882?focusedWorklogId=729689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729689
]
ASF GitHub Bot logged work on BEAM-13882:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 14:29
Start Date: 18/Feb/22 14:29
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#16895:
URL: https://github.com/apache/beam/pull/16895#discussion_r810048252
##########
File path: playground/backend/internal/fs_tool/lc_constructor.go
##########
@@ -39,6 +40,7 @@ func newCompilingLifeCycle(pipelineId uuid.UUID,
pipelinesFolder, sourceFileExte
absExecFilePath, _ := filepath.Abs(filepath.Join(absExecFileFolderPath,
execFileName))
absBaseFolderPath, _ := filepath.Abs(baseFileFolder)
absLogFilePath, _ := filepath.Abs(filepath.Join(absBaseFolderPath,
logFileName))
+ absGraphFilePath, _ := filepath.Abs(filepath.Join(absBaseFolderPath,
utils.GraphFileName))
Review comment:
Why do we keep the name of the file where we place the graph in the
`utils` package? Can we do the same as we do with the `logs.log` constant in
the `fs_tool` package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729689)
Time Spent: 20m (was: 10m)
> [Playground] Increase test coverage for the validators package
> --------------------------------------------------------------
>
> Key: BEAM-13882
> URL: https://issues.apache.org/jira/browse/BEAM-13882
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Daria Malkova
> Priority: P2
> Labels: beam-playground-backend
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Need to add unit tests to increase test coverage for the validators package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
