[
https://issues.apache.org/jira/browse/BEAM-13882?focusedWorklogId=733772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733772
]
ASF GitHub Bot logged work on BEAM-13882:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 08:51
Start Date: 28/Feb/22 08:51
Worklog Time Spent: 10m
Work Description: daria-malkova commented on a change in pull request
#16895:
URL: https://github.com/apache/beam/pull/16895#discussion_r815683794
##########
File path: playground/backend/internal/fs_tool/lc_constructor.go
##########
@@ -39,6 +40,7 @@ func newCompilingLifeCycle(pipelineId uuid.UUID,
pipelinesFolder, sourceFileExte
absExecFilePath, _ := filepath.Abs(filepath.Join(absExecFileFolderPath,
execFileName))
absBaseFolderPath, _ := filepath.Abs(baseFileFolder)
absLogFilePath, _ := filepath.Abs(filepath.Join(absBaseFolderPath,
logFileName))
+ absGraphFilePath, _ := filepath.Abs(filepath.Join(absBaseFolderPath,
utils.GraphFileName))
Review comment:
Cause it is utils and we can keep constant there and access it
everywhere without redefining it multiple times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733772)
Time Spent: 0.5h (was: 20m)
> [Playground] Increase test coverage for the validators package
> --------------------------------------------------------------
>
> Key: BEAM-13882
> URL: https://issues.apache.org/jira/browse/BEAM-13882
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Daria Malkova
> Priority: P2
> Labels: beam-playground-backend
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Need to add unit tests to increase test coverage for the validators package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
