[
https://issues.apache.org/jira/browse/BEAM-13917?focusedWorklogId=733381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733381
]
ASF GitHub Bot logged work on BEAM-13917:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/22 22:03
Start Date: 25/Feb/22 22:03
Worklog Time Spent: 10m
Work Description: damccorm opened a new pull request #16956:
URL: https://github.com/apache/beam/pull/16956
This adds tests to the dbio read functionality using an in-memory local DB.
There are a couple things to consider here:
1) This was the best in-memory go db driver I could find, and it works well
for the read tests, but I couldn't get it to test the writes because it throws
an error at `SELECT ... WHERE 1 = 0` (called
[here](https://github.com/apache/beam/blob/ba2aef5972eca7322ae68f81bafd52d894e43edf/sdks/go/pkg/beam/io/databaseio/database.go#L166)
to validate the schema) because its still building out full syntactical
support. That's why I'm only testing reads.
2) This package isn't incredibly widely used, so there's probably some risk
in taking a test dependency on it. If we ever need to upgrade and that's an
issue we can always just get rid of the test though. [Package
repo](https://github.com/proullon/ramsql) here, its got ~500 stars. On the flip
side, it has gotten reasonably consistent patches. Are there requirements for
us to include this package as a dependency?
All in all, I think the pros of getting a full test of the actual
functionality (vs testing small pieces of the code) outweigh the cons here, but
I'm open to thoughts from others. Its definitely not a straightforward yes.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733381)
Remaining Estimate: 0h
Time Spent: 10m
> Increase unit testing coverage in the databaseio package
> --------------------------------------------------------
>
> Key: BEAM-13917
> URL: https://issues.apache.org/jira/browse/BEAM-13917
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [databaseio
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/io/databaseio]
> We want code coverage at or above 50%, it is currently at 20.4%.
> This task will require mocking a database.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
