[
https://issues.apache.org/jira/browse/BEAM-13917?focusedWorklogId=733407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733407
]
ASF GitHub Bot logged work on BEAM-13917:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/22 23:09
Start Date: 25/Feb/22 23:09
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #16956:
URL: https://github.com/apache/beam/pull/16956#issuecomment-1051345639
To answer the description questions: The risk in taking this dep is minimal:
1. Test dependencies don't get compiled into non-test code.
2. We have it working at version X, and depend on that. Even if they make
breaking changes, we'll still be on version X. The main risk is if a user
depends on X+N with breaking behaviors and then also runs Our tests, which
would hoist things up to X+N. But it's only in tests, so it still doesn't
break user code.
The only other alternative is setting up an in memory SQL lite instance
instead.
Overall, this package should likely be commented and direct users to the
Xlang JDBCIO package instead, which will perform better at the moment. We will
want to revamp this for Go native implementation eventually, but this is better
than nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733407)
Time Spent: 1h 10m (was: 1h)
> Increase unit testing coverage in the databaseio package
> --------------------------------------------------------
>
> Key: BEAM-13917
> URL: https://issues.apache.org/jira/browse/BEAM-13917
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [databaseio
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/io/databaseio]
> We want code coverage at or above 50%, it is currently at 20.4%.
> This task will require mocking a database.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
