[
https://issues.apache.org/jira/browse/BEAM-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498368#comment-17498368
]
Robert Burke commented on BEAM-13939:
-------------------------------------
[~thempatel] (just going to be pro-ping for the time being)
A fair point! Ultimately, we accept most approaches, but if one is looking for
feedback, a PR or at least a [Draft
PR|https://github.blog/2019-02-14-introducing-draft-pull-requests/] will allow
someone to comment, and see the diff more easily. Draft PRs also avoid needing
informal "it's not done yet, so don't merge" by having Github prevent the
merge from happening in the first place. It's clearly a Draft in that stage.
PR will also automatically or at least allow the automated tests to run, short
cutting much manual static analysis. This is varying degrees of useful (depends
on how some targets fail), and can at least confirm if things work as expected.
There's nothing wrong with just the Branch Diff link though, if you're not
looking for feedback on any specific file/line, since it demonstrates the
concept.
In this specific case, since the change affects All of Beam, it's probably
better to be aware of the Test Everything that an early PR provides.
> Go SDK: Protobuf namespace conflict
> -----------------------------------
>
> Key: BEAM-13939
> URL: https://issues.apache.org/jira/browse/BEAM-13939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go
> Affects Versions: 2.36.0
> Reporter: Milan Patel
> Priority: P2
> Labels: easyfix
> Attachments: demobug.zip
>
>
> The Go SDK generated grpc protobufs are not namespaced with enough
> granularity. If a user has another external dependency with the same protobuf
> file registered with the proto runtime, their compiled binary will panic at
> runtime pointing the user to this [doc
> page|https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict].
>
> In the interim, following the instructions to add either ldflags to the
> compiler or an environment var to the binary works, but this is an unideal
> solution since only one of the duplicate proto specifications will be
> accessible from a [global
> registry|https://pkg.go.dev/google.golang.org/[email protected]/reflect/protoregistry].
>
> Ask: Regenerate the go protos such that descriptors like
> [these|https://github.com/apache/beam/blob/84353a7c973d3acaaa56d81c265dce7193a56be5/sdks/go/pkg/beam/model/pipeline_v1/metrics.pb.go#L797-L811]
> are outputted with filenames that are more granular, such as a filename that
> includes the directory structure of the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
