[
https://issues.apache.org/jira/browse/BEAM-14012?focusedWorklogId=734918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734918
]
ASF GitHub Bot logged work on BEAM-14012:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 20:42
Start Date: 01/Mar/22 20:42
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on pull request #16978:
URL: https://github.com/apache/beam/pull/16978#issuecomment-1055840342
R: @damccorm @lostluck
I think I understand how this works now on a very basic level (which is why
I added the exit code 1 output for vet too.) For some reason fmt was always
returning exit code 1 on its own though, which is why we don't actually care if
it executes here and continue on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 734918)
Time Spent: 20m (was: 10m)
> Add go fmt CI check
> -------------------
>
> Key: BEAM-14012
> URL: https://issues.apache.org/jira/browse/BEAM-14012
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now, we occasionally notice that checked in files have not been
> formatted properly (e.g. [https://github.com/apache/beam/pull/16973).] It
> would be nice to catch these as a precommit check (it could be something as
> simple as a quick Actions or Jira job that runs:
> ```
> go fmt sdks/go/...
> git diff-index --quiet HEAD – || (echo "Run go fmt before checking in
> changes" && exit 1)}}
> {{```}}
> That way we push the work to the original authors and let robots enforce
> linting :)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
