[
https://issues.apache.org/jira/browse/BEAM-14012?focusedWorklogId=734926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734926
]
ASF GitHub Bot logged work on BEAM-14012:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 20:55
Start Date: 01/Mar/22 20:55
Worklog Time Spent: 10m
Work Description: damccorm commented on a change in pull request #16978:
URL: https://github.com/apache/beam/pull/16978#discussion_r817131036
##########
File path: .github/workflows/go_tests.yml
##########
@@ -49,5 +49,7 @@ jobs:
flags: go
files: ./sdks/go/pkg/coverage.txt
name: go-unittests
+ - name: Run fmt
+ run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD
|| (echo "Run go fmt before checking in changes" && exit 1)
Review comment:
Rather than using `cd`, you can specify a working-directory (see
https://github.com/apache/beam/blob/b07840e925b910fffee85d3bcdb67468965b7770/.github/workflows/python_tests.yml#L77-L79
for an example). Its not a bad idea to update the rest of the file, but I'll
leave that to your discretion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 734926)
Time Spent: 40m (was: 0.5h)
> Add go fmt CI check
> -------------------
>
> Key: BEAM-14012
> URL: https://issues.apache.org/jira/browse/BEAM-14012
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Right now, we occasionally notice that checked in files have not been
> formatted properly (e.g. [https://github.com/apache/beam/pull/16973).] It
> would be nice to catch these as a precommit check (it could be something as
> simple as a quick Actions or Jira job that runs:
> ```
> go fmt sdks/go/...
> git diff-index --quiet HEAD – || (echo "Run go fmt before checking in
> changes" && exit 1)}}
> {{```}}
> That way we push the work to the original authors and let robots enforce
> linting :)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
