[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=735493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735493
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/22 18:47
Start Date: 02/Mar/22 18:47
Worklog Time Spent: 10m
Work Description: kileys commented on a change in pull request #16609:
URL: https://github.com/apache/beam/pull/16609#discussion_r817988930
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/AutoComplete.java
##########
@@ -467,7 +467,6 @@ public void processElement(ProcessContext c) {
public static void runAutocompletePipeline(Options options) throws
IOException {
- options.setBigQuerySchema(FormatForBigquery.getSchema());
Review comment:
Why are these being removed?
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java
##########
@@ -381,6 +381,13 @@ private QueryResponse queryWithRetries(
/** Creates a new dataset. */
public void createNewDataset(String projectId, String datasetId)
throws IOException, InterruptedException {
+ createNewDataset(projectId, datasetId, null);
+ }
+
+ /** Creates a new dataset with defaultTableExpiration in ms. */
+ public void createNewDataset(
+ String projectId, String datasetId, @Nullable Long
defaultTableExpiration)
Review comment:
```suggestion
String projectId, String datasetId, @Nullable Long
defaultTableExpirationMs)
```
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleIT.java
##########
@@ -1,100 +0,0 @@
-/*
Review comment:
Something wrong with this test?
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -285,8 +285,6 @@ createJavaExamplesArchetypeValidationTask(type:
'Quickstart', runner: 'FlinkLoca
task examplesIntegrationTest(type: Test) {
group = "Verification"
- // Disable gradle cache
- outputs.upToDateWhen { false }
Review comment:
Why is this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735493)
Time Spent: 61h 20m (was: 61h 10m)
> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 61h 20m
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
