[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=737807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737807
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/22 21:41
Start Date: 07/Mar/22 21:41
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #16609:
URL: https://github.com/apache/beam/pull/16609#discussion_r821126227
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/AutoComplete.java
##########
@@ -467,7 +467,6 @@ public void processElement(ProcessContext c) {
public static void runAutocompletePipeline(Options options) throws
IOException {
- options.setBigQuerySchema(FormatForBigquery.getSchema());
Review comment:
For these examples, the schema is added directly to the transform
https://github.com/apache/beam/blob/46155767ecf0694d86257e9c3a8b5fd5bbc0afbb/examples/java/src/main/java/org/apache/beam/examples/complete/AutoComplete.java#L515
using `FormatForBigquery.getSchema()`, not sure why was added to options if it
wasn't used from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737807)
Time Spent: 62h 50m (was: 62h 40m)
> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 62h 50m
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
