[
https://issues.apache.org/jira/browse/BEAM-14157?focusedWorklogId=746853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746853
]
ASF GitHub Bot logged work on BEAM-14157:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/22 20:15
Start Date: 23/Mar/22 20:15
Worklog Time Spent: 10m
Work Description: scwhittle commented on a change in pull request #17162:
URL: https://github.com/apache/beam/pull/17162#discussion_r833684035
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -936,7 +936,11 @@ protected void onResponse(StreamingGetWorkResponseChunk
chunk) {
.execute(
() -> {
try {
- send(extension);
+ synchronized (this) {
+ if (!clientClosed.get()) {
Review comment:
To keep contract the same for other call-sites you could throw
IllegalStateException yourself if the client is closed instead of relying on
grpc to do so (since that adds delay it sounds like).
LGTM though if you want to put a comment/TODO for that to try to get this in
the next release. You'll have to find someone else to merge though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 746853)
Time Spent: 50m (was: 40m)
> Don't request work on a closed windmill GetWorkStream
> -----------------------------------------------------
>
> Key: BEAM-14157
> URL: https://issues.apache.org/jira/browse/BEAM-14157
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Arun Pandian
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> GetWorkStream could send new getwork requests on a closed stream
> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java#L939
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
