[
https://issues.apache.org/jira/browse/BEAM-14157?focusedWorklogId=747295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747295
]
ASF GitHub Bot logged work on BEAM-14157:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/22 15:44
Start Date: 24/Mar/22 15:44
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#17162:
URL: https://github.com/apache/beam/pull/17162#discussion_r834455046
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -848,7 +848,11 @@ public void run() {
new TimerTask() {
@Override
public void run() {
- refreshActiveWork();
+ try {
+ refreshActiveWork();
+ } catch (RuntimeException e) {
+ LOG.warn("Failed to refresh active work: ", e);
Review comment:
Sorry I'm not that familiar with this code, could you help me understand
the change?
I'm assuming that this `refreshActiveWork()` call ultimately calls
`GrpcWindmiillServier.send()`, so we're catching the error here and logging it.
This is an improvement because previously that situation caused stalled GetWork
streams?
Are there other places where we should be catching the
`IllegalStateException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 747295)
Time Spent: 1h 40m (was: 1.5h)
> Don't request work on a closed windmill GetWorkStream
> -----------------------------------------------------
>
> Key: BEAM-14157
> URL: https://issues.apache.org/jira/browse/BEAM-14157
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Arun Pandian
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> GetWorkStream could send new getwork requests on a closed stream
> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java#L939
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
