[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=749147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749147
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/22 07:08
Start Date: 29/Mar/22 07:08
Worklog Time Spent: 10m
Work Description: thiagotnunes commented on a change in pull request
#17200:
URL: https://github.com/apache/beam/pull/17200#discussion_r837126701
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/TimestampRangeTracker.java
##########
@@ -45,12 +49,20 @@
public class TimestampRangeTracker extends RestrictionTracker<TimestampRange,
Timestamp>
implements HasProgress {
+ private static final Logger LOG =
LoggerFactory.getLogger(TimestampRangeTracker.class);
protected TimestampRange range;
protected @Nullable Timestamp lastAttemptedPosition;
protected @Nullable Timestamp lastClaimedPosition;
+ protected TimeFunction timeFunction;
Review comment:
Oh never mind, you can not, because we need a google cloud Timestamp
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/TimestampRangeTracker.java
##########
@@ -45,12 +49,20 @@
public class TimestampRangeTracker extends RestrictionTracker<TimestampRange,
Timestamp>
implements HasProgress {
+ private static final Logger LOG =
LoggerFactory.getLogger(TimestampRangeTracker.class);
protected TimestampRange range;
protected @Nullable Timestamp lastAttemptedPosition;
protected @Nullable Timestamp lastClaimedPosition;
+ protected TimeFunction timeFunction;
Review comment:
You can use Java Clock instead:
https://docs.oracle.com/javase/8/docs/api/java/time/Clock.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 749147)
Time Spent: 62h 50m (was: 62h 40m)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Assignee: Thiago Nunes
> Priority: P2
> Fix For: 2.37.0
>
> Time Spent: 62h 50m
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
