[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=750720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-750720
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/22 03:51
Start Date: 31/Mar/22 03:51
Worklog Time Spent: 10m
Work Description: hengfengli commented on a change in pull request #17200:
URL: https://github.com/apache/beam/pull/17200#discussion_r839145546
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java
##########
@@ -187,6 +193,7 @@ public ProcessContinuation run(
changeStreamRecordMapper.toChangeStreamRecords(
updatedPartition, resultSet.getCurrentRowAsStruct(),
resultSet.getMetadata());
+ double recordsBytes = 0D;
Review comment:
Yes, I did this way originally. But I found that all records here come
from a single row so they have the same commit timestamp. That's why I
aggregate the bytes of all records first and then update once instead of
calling update for each record.
Do you think I should change it or keep the current way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 750720)
Time Spent: 64h 10m (was: 64h)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Assignee: Thiago Nunes
> Priority: P2
> Fix For: 2.37.0
>
> Time Spent: 64h 10m
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
