[
https://issues.apache.org/jira/browse/BEAM-13939?focusedWorklogId=749806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749806
]
ASF GitHub Bot logged work on BEAM-13939:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/22 02:22
Start Date: 30/Mar/22 02:22
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #16961:
URL: https://github.com/apache/beam/pull/16961#issuecomment-1082549553
Thanks for taking on this change, @thempatel .
The new suggested import aliases for Python (`proto_file_name.message_name`,
such as `beam_runner_api_pb2.SideInput`) sounds good to me. It also does not
preclude from using the fully-qualified import path if someone would like that.
For further steps on this PR I'd suggest to cleanup the commit history if
comments from other reviewers have been addressed.
Please do keep separate commit(s) for tooling changes, for regenerated stubs
and fixes in the code to use new namespaces. I think it would be useful to
break it down instead of all squashing into one change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 749806)
Time Spent: 23h (was: 22h 50m)
> Go SDK: Protobuf namespace conflict
> -----------------------------------
>
> Key: BEAM-13939
> URL: https://issues.apache.org/jira/browse/BEAM-13939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go
> Affects Versions: 2.36.0
> Reporter: Milan Patel
> Priority: P2
> Attachments: demobug.zip
>
> Time Spent: 23h
> Remaining Estimate: 0h
>
> The Go SDK generated grpc protobufs are not namespaced with enough
> granularity. If a user has another external dependency with the same protobuf
> file registered with the proto runtime, their compiled binary will panic at
> runtime pointing the user to this [doc
> page|https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict].
>
> In the interim, following the instructions to add either ldflags to the
> compiler or an environment var to the binary works, but this is an unideal
> solution since only one of the duplicate proto specifications will be
> accessible from a [global
> registry|https://pkg.go.dev/google.golang.org/[email protected]/reflect/protoregistry].
>
> Ask: Regenerate the go protos such that descriptors like
> [these|https://github.com/apache/beam/blob/84353a7c973d3acaaa56d81c265dce7193a56be5/sdks/go/pkg/beam/model/pipeline_v1/metrics.pb.go#L797-L811]
> are outputted with filenames that are more granular, such as a filename that
> includes the directory structure of the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
