[
https://issues.apache.org/jira/browse/BEAM-13939?focusedWorklogId=751342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751342
]
ASF GitHub Bot logged work on BEAM-13939:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/22 01:49
Start Date: 01/Apr/22 01:49
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #16961:
URL: https://github.com/apache/beam/pull/16961#issuecomment-1085307480
> So the vast majority of Python changes seem to be unrelated to this
(mostly go specific, already very large) change. Is there a way we could break
them out and review them separately? The one change I see is that we (now) have
to do renaming of the proto files in apache_beam/portability/api back to a flat
structure (and fix their internal imports).
Milan can confirm, but since the changes are rooted in changing how the
proto files import each other, I don't know how separable each change at a PR
level.
Might be able to organize the changes as commits with: "proto file changes"
"generator changes" "go generated code" "python things."... granularity though.
I'm ambivalent, since the go side is finished review at this point, and I
don't understand the nature of the python side of the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 751342)
Time Spent: 23.5h (was: 23h 20m)
> Go SDK: Protobuf namespace conflict
> -----------------------------------
>
> Key: BEAM-13939
> URL: https://issues.apache.org/jira/browse/BEAM-13939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go
> Affects Versions: 2.36.0
> Reporter: Milan Patel
> Priority: P2
> Attachments: demobug.zip
>
> Time Spent: 23.5h
> Remaining Estimate: 0h
>
> The Go SDK generated grpc protobufs are not namespaced with enough
> granularity. If a user has another external dependency with the same protobuf
> file registered with the proto runtime, their compiled binary will panic at
> runtime pointing the user to this [doc
> page|https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict].
>
> In the interim, following the instructions to add either ldflags to the
> compiler or an environment var to the binary works, but this is an unideal
> solution since only one of the duplicate proto specifications will be
> accessible from a [global
> registry|https://pkg.go.dev/google.golang.org/[email protected]/reflect/protoregistry].
>
> Ask: Regenerate the go protos such that descriptors like
> [these|https://github.com/apache/beam/blob/84353a7c973d3acaaa56d81c265dce7193a56be5/sdks/go/pkg/beam/model/pipeline_v1/metrics.pb.go#L797-L811]
> are outputted with filenames that are more granular, such as a filename that
> includes the directory structure of the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
