[ 
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=752018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752018
 ]

ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Apr/22 02:17
            Start Date: 03/Apr/22 02:17
    Worklog Time Spent: 10m 
      Work Description: sfc-gh-kbregula opened a new pull request #17257:
URL: https://github.com/apache/beam/pull/17257


   Fixed warnings found by error checker or JetBrains IDE.
   
   The least obvious might be the changes to the `SnowflakeService` interface, 
which has now become `SnowflakeService[s]`, but I had to do that because 
`SnowflakeService` was a generic class, which made it difficult to fix rawtypes 
warnings and made the code overly complicated.
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 752018)
    Time Spent: 66h 10m  (was: 66h)

> Fix errorprone ignored warnings
> -------------------------------
>
>                 Key: BEAM-11936
>                 URL: https://issues.apache.org/jira/browse/BEAM-11936
>             Project: Beam
>          Issue Type: Task
>          Components: build-system, runner-core, sdk-java-core, 
> sdk-java-harness
>            Reporter: Brian Hulette
>            Priority: P3
>          Time Spent: 66h 10m
>  Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148) 
> required ignoring a lot of new warnings. We should fix the offending code and 
> re-enable these warnings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to