[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=752532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752532
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 22:30
Start Date: 04/Apr/22 22:30
Worklog Time Spent: 10m
Work Description: sfc-gh-kbregula commented on code in PR #17257:
URL: https://github.com/apache/beam/pull/17257#discussion_r842187978
##########
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServices.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.snowflake.services;
+
+import java.io.Serializable;
+
+/** Interface which defines common methods for interacting with Snowflake. */
+public interface SnowflakeServices extends Serializable {
Review Comment:
This class has been marked public, but should not be used in public because
it touches upon very internal things. I have now added annotations to mark
these methods as only available for tests.
I think we shouldn't be concerned about the backward compatibility of this
class any more than it does when making a change to BigQueryServices.
https://github.com/apache/beam/commits/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
Issue Time Tracking
-------------------
Worklog Id: (was: 752532)
Time Spent: 67h (was: 66h 50m)
> Fix errorprone ignored warnings
> -------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Priority: P3
> Time Spent: 67h
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
