[
https://issues.apache.org/jira/browse/BEAM-6942?focusedWorklogId=226425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226425
]
ASF GitHub Bot logged work on BEAM-6942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/19 23:59
Start Date: 11/Apr/19 23:59
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8225: [BEAM-6942]
Make modifications to pipeline options to be visible to all views.
URL: https://github.com/apache/beam/pull/8225#discussion_r274716309
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -70,9 +70,9 @@ class TemplateUserOptions(PipelineOptions):
@classmethod
def _add_argparse_args(cls, parser):
- parser.add_value_provider_argument('--vp-arg1', default='start')
- parser.add_value_provider_argument('--vp-arg2')
- parser.add_argument('--non-vp-arg')
+ parser.add_value_provider_argument('--vp_arg1', default='start')
Review comment:
I want to discourage using dashes in the name. Argparse considers them
valid, but as @udim has checked, flags with dashes passed in `**kwargs`
parameter of PipelineOptions constructor will not overwrite flags with dashes
defined in `_add_argparse_args()` method. Argparse normalizes dashes to
underscores, but Beam does not. I was thinking about sending a PR to emit a
warning when dashes are used to encourage users to stop using them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226425)
Time Spent: 7h 50m (was: 7h 40m)
> Pipeline options to experiment propagation is not working in Dataflow runner.
> -----------------------------------------------------------------------------
>
> Key: BEAM-6942
> URL: https://issues.apache.org/jira/browse/BEAM-6942
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Relevant code:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L356-L388]
> 3 experiments/options are affected. We need to fix it in 2.12.0
> cc: [~altay] [~apilloud]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
