[
https://issues.apache.org/jira/browse/BEAM-6942?focusedWorklogId=226426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226426
]
ASF GitHub Bot logged work on BEAM-6942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/19 00:04
Start Date: 12/Apr/19 00:04
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8225: [BEAM-6942]
Make modifications to pipeline options to be visible to all views.
URL: https://github.com/apache/beam/pull/8225#discussion_r274719245
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -150,28 +160,48 @@ def __init__(self, flags=None, **kwargs):
arguments and then parse the command line specified by flags or by default
the one obtained from sys.argv.
- The subclasses are not expected to require a redefinition of __init__.
+ The subclasses of PipelineOptions should not redefine __init__.
Review comment:
Things should work. Do you prefer a different wording? `The subclasses of
PipelineOptions do not need to redefine __init__` perhaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226426)
Time Spent: 8h (was: 7h 50m)
> Pipeline options to experiment propagation is not working in Dataflow runner.
> -----------------------------------------------------------------------------
>
> Key: BEAM-6942
> URL: https://issues.apache.org/jira/browse/BEAM-6942
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Relevant code:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L356-L388]
> 3 experiments/options are affected. We need to fix it in 2.12.0
> cc: [~altay] [~apilloud]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
