[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=752446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752446
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 19:07
Start Date: 04/Apr/22 19:07
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r842056277
##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -631,6 +647,8 @@ func nextRetState(cur retState, transition ReturnKind)
(retState, error) {
return -1, errEventTimeRetPrecedence
case RetValue, RetRTracker:
return rsOutput, nil
+ case RetProcessContinuation:
+ return rsProcessContinuation, nil
Review Comment:
From a technical standpoint this LGTM, I'm not so sure about the ordering of
the changes though. Specifically, what I'm worried about is the potential for:
1) This PR takes away the validation that says you can't have a
ProcessContinuation type as a return type.
2) The Sdk gets cut/released with version X.
3) This PR gets completed and we doc the change for version Y.
4) A user still on version X sees the doc changes and tries to use the
ProcessContinuation, getting an error at pipeline run time (or even worse,
silently seeing no errors)
While I'm 100% all about breaking PRs up, as a rule I would prefer we don't
expose the user facing API until the last incremental PR so that we avoid the
potential for something like that happening. Basically, I don't want to
_expose_ any incomplete features.
I would prefer we get rid of these 2 lines (or at least comment them out) so
that there is no ambiguity about what is supported and users get a pipeline
construction time error indicating exactly what the problem is.
Issue Time Tracking
-------------------
Worklog Id: (was: 752446)
Time Spent: 2h (was: 1h 50m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
