[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=752486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752486
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 19:59
Start Date: 04/Apr/22 19:59
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r842091890
##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -631,6 +647,8 @@ func nextRetState(cur retState, transition ReturnKind)
(retState, error) {
return -1, errEventTimeRetPrecedence
case RetValue, RetRTracker:
return rsOutput, nil
+ case RetProcessContinuation:
+ return rsProcessContinuation, nil
Review Comment:
Ordering-wise, what we could do here is comment out all of the information
here that allows a RetProcessContinuation and wait until it's fully piped
through. I'm not worried about the follow-up running over a branch cut at the
moment given the timing, but I do understand where the worst-cast scenario is
here since this pushes the error to DoFn invocation time.
Issue Time Tracking
-------------------
Worklog Id: (was: 752486)
Time Spent: 2.5h (was: 2h 20m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
