[ 
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=753698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753698
 ]

ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Apr/22 21:24
            Start Date: 06/Apr/22 21:24
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r844235564


##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -302,6 +305,16 @@ func (u *Fn) OutEventTime() (pos int, exists bool) {
        return -1, false
 }
 
+// ProcessContinuation returns (index, tru) iff the function returns a process 
continuation.

Review Comment:
   ```suggestion
   // ProcessContinuation returns (index, true) iff the function returns a 
process continuation.
   ```



##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -601,6 +616,8 @@ func nextParamState(cur paramState, transition FnParamKind) 
(paramState, error)
 var (
        errEventTimeRetPrecedence = errors.New("beam.EventTime must be first 
return parameter")
        errErrorPrecedence        = errors.New("error must be the final return 
parameter")
+       // TODO(BEAM-11104): Enable process continuations as a valid return 
value.
+       errContinuationSupport = errors.New("process continuations are not yet 
supported")

Review Comment:
   ```suggestion
        errContinuationSupport = errors.New("process continuations are not 
supported in this SDK release; see 
https://issues.apache.org/jira/browse/BEAM-11104 for the feature's current 
status")
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 753698)
    Time Spent: 4h 40m  (was: 4.5h)

> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
>                 Key: BEAM-11104
>                 URL: https://issues.apache.org/jira/browse/BEAM-11104
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Priority: P3
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and 
> the programming guide updated with SDF content.)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to