[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=755308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755308
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 16:42
Start Date: 11/Apr/22 16:42
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17334:
URL: https://github.com/apache/beam/pull/17334#discussion_r847533568
##########
sdks/go/pkg/beam/core/runtime/exec/sdf.go:
##########
@@ -361,7 +371,7 @@ func (n *ProcessSizedElementsAndRestrictions)
ProcessElement(_ context.Context,
n.rt = rt
n.elm = elm
n.SU <- n
- err := n.PDo.processSingleWindow(&MainInput{Key: wElm,
Values: mainIn.Values, RTracker: rt})
+ _, err := n.PDo.processSingleWindow(&MainInput{Key:
wElm, Values: mainIn.Values, RTracker: rt})
Review Comment:
This is a placeholder as we determined that an SDF shouldn't be allowed to
explode windows. For now I just blank-assigned the field but in a later PR I
believe we're going to remove that case altogether and return an error.
Issue Time Tracking
-------------------
Worklog Id: (was: 755308)
Time Spent: 6h (was: 5h 50m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> Design doc:
> https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
