[
https://issues.apache.org/jira/browse/BEAM-6894?focusedWorklogId=226610&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226610
]
ASF GitHub Bot logged work on BEAM-6894:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/19 12:07
Start Date: 12/Apr/19 12:07
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8270: [BEAM-6894]
Updates Dataflow runner to support external ParDos.
URL: https://github.com/apache/beam/pull/8270#discussion_r274864591
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -476,18 +485,24 @@ def _get_side_input_encoding(self, input_encoding):
def _get_encoded_output_coder(self, transform_node, window_value=True):
"""Returns the cloud encoding of the coder for the output of a
transform."""
+ # Main output key for external transforms for Java SDK received through
Review comment:
It seems very hacky to have this kind of special casing here.
Instead, looking at the code below, we could let element_type be the type of
the only value in this map iff there is 1 value, and typehints.Any otherwise.
For window_coder further below, no (leaf) transform produces
differently-windowed values, so just choose any output arbitrarily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226610)
Time Spent: 2h (was: 1h 50m)
> ExternalTransform.expand() does not create the proper AppliedPTransform
> sub-graph
> ---------------------------------------------------------------------------------
>
> Key: BEAM-6894
> URL: https://issues.apache.org/jira/browse/BEAM-6894
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> 'ExternalTransform.expand()' can be used to expand a remote transform and
> build the correct runner-api subgraph for that transform. However currently
> we do not modify the AppliedPTransform sub-graph correctly during this
> process. Relevant code location here.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/external.py#L135]
>
> Without this, DataflowRunner that relies in this object graph (not just the
> runner API proto) to build the job submission request to Dataflow service
> cannot construct this request properly.
>
> cc: [~robertwb]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
