[
https://issues.apache.org/jira/browse/BEAM-6894?focusedWorklogId=229544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229544
]
ASF GitHub Bot logged work on BEAM-6894:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/19 02:33
Start Date: 18/Apr/19 02:33
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #8270:
[BEAM-6894] Updates Dataflow runner to support external ParDos.
URL: https://github.com/apache/beam/pull/8270#discussion_r275563792
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -662,7 +682,23 @@ def run_GroupByKey(self, transform_node, options):
PropertyNames.SERIALIZED_FN,
self.serialize_windowing_strategy(windowing))
- def run_ParDo(self, transform_node, options):
+ def run_RunnerAPIPTransformHolder(self, transform_node, options):
+ """Adding Dataflow runner job description for transform holder objects.
+
+ These holder transform objects are generated for some of the transforms
that
+ become available after a cross-language transform expansion, usually if the
+ corresponding transform object cannot be generated in Python SDK (for
+ example, a python `ParDo` transform cannot be generated without a
serialized
+ Python `DoFn` object).
+ """
+ assert transform_node.transform.urn()
+ if common_urns.primitives.PAR_DO.urn == transform_node.transform.urn():
+ self.run_ParDo(transform_node, options, True)
+ return
+
+ raise NotImplementedError('run_RunnerAPIPayloadHolder')
+
+ def run_ParDo(self, transform_node, options, proto_holder=False):
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229544)
Time Spent: 4.5h (was: 4h 20m)
> ExternalTransform.expand() does not create the proper AppliedPTransform
> sub-graph
> ---------------------------------------------------------------------------------
>
> Key: BEAM-6894
> URL: https://issues.apache.org/jira/browse/BEAM-6894
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> 'ExternalTransform.expand()' can be used to expand a remote transform and
> build the correct runner-api subgraph for that transform. However currently
> we do not modify the AppliedPTransform sub-graph correctly during this
> process. Relevant code location here.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/external.py#L135]
>
> Without this, DataflowRunner that relies in this object graph (not just the
> runner API proto) to build the job submission request to Dataflow service
> cannot construct this request properly.
>
> cc: [~robertwb]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
