[ 
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=755323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755323
 ]

ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 17:03
            Start Date: 11/Apr/22 17:03
    Worklog Time Spent: 10m 
      Work Description: jrmccluskey commented on code in PR #17334:
URL: https://github.com/apache/beam/pull/17334#discussion_r847551453


##########
sdks/go/pkg/beam/core/runtime/exec/fullvalue.go:
##########
@@ -35,9 +36,10 @@ type FullValue struct {
        Elm  interface{} // Element or KV key.
        Elm2 interface{} // KV value, if not invalid
 
-       Timestamp typex.EventTime
-       Windows   []typex.Window
-       Pane      typex.PaneInfo
+       Timestamp    typex.EventTime
+       Windows      []typex.Window
+       Pane         typex.PaneInfo
+       Continuation sdf.ProcessContinuation

Review Comment:
   I'm not 100% sure, but I don't think so? We could pull the continuation out 
and set the field in the FullValue back to nil after we retrieve it though. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755323)
    Time Spent: 6h 50m  (was: 6h 40m)

> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
>                 Key: BEAM-11104
>                 URL: https://issues.apache.org/jira/browse/BEAM-11104
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Jack McCluskey
>            Priority: P3
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> Design doc: 
> https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to