[
https://issues.apache.org/jira/browse/BEAM-11105?focusedWorklogId=757160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757160
]
ASF GitHub Bot logged work on BEAM-11105:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 18:57
Start Date: 14/Apr/22 18:57
Worklog Time Spent: 10m
Work Description: damccorm commented on PR #17374:
URL: https://github.com/apache/beam/pull/17374#issuecomment-1099531103
R: @lostluck
@lostluck for expediency/context, I'll probably just keep looping you into
the watermark reviews immediately, rather than letting the bot round robin. If
you disagree with that decision, let me know.
This one is a bigger PR than I'd prefer. If you want me to split it up, let
me know and I will - the advantage here is that we get to see the full
functionality working E2E. If you want to review it in pieces, I'd split it
into:
- the validation + generation (graph/fn.go, graph/fn_test.go, genx/genx.go,
genx/genx_test.go)
- the invoker changes (exec/sdf_invokers.go, exec/sdf_invokers_test.go)
- the sdf execution + encoding changes (exec/sdf.go, exec/sdf_test.go,
pardo.go, exec/dynsplit_test.go)
If you would like me to split it up, that is how I would do it
Issue Time Tracking
-------------------
Worklog Id: (was: 757160)
Time Spent: 4.5h (was: 4h 20m)
> [Go SDK] Watermark Estimation
> -----------------------------
>
> Key: BEAM-11105
> URL: https://issues.apache.org/jira/browse/BEAM-11105
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Danny McCormick
> Priority: P3
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Allow self checkpointing SplittableDoFns to specify a watermark estimator.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
