[
https://issues.apache.org/jira/browse/BEAM-11105?focusedWorklogId=757161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757161
]
ASF GitHub Bot logged work on BEAM-11105:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 18:58
Start Date: 14/Apr/22 18:58
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17374:
URL: https://github.com/apache/beam/pull/17374#discussion_r850722773
##########
sdks/go/pkg/beam/pardo.go:
##########
@@ -64,9 +66,16 @@ func TryParDo(s Scope, dofn interface{}, col PCollection,
opts ...Option) ([]PCo
}
var rc *coder.Coder
+ // Sdfs will always encode restrictions as KV<restriction, watermark
state | nil>
if fn.IsSplittable() {
sdf := (*graph.SplittableDoFn)(fn)
- rc, err = inferCoder(typex.New(sdf.RestrictionT()))
+ restT := typex.New(sdf.RestrictionT())
+ // If no watermark estimator state, use boolean as a placeholder
Review Comment:
@lostluck - I'd appreciate input on this, is there an easy way to encode nil
state? Using a bool here isn't a huge deal performance-wise, but its kinda odd
and not really ideal.
Issue Time Tracking
-------------------
Worklog Id: (was: 757161)
Time Spent: 4h 40m (was: 4.5h)
> [Go SDK] Watermark Estimation
> -----------------------------
>
> Key: BEAM-11105
> URL: https://issues.apache.org/jira/browse/BEAM-11105
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Danny McCormick
> Priority: P3
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Allow self checkpointing SplittableDoFns to specify a watermark estimator.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
