[
https://issues.apache.org/jira/browse/BEAM-14306?focusedWorklogId=758472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758472
]
ASF GitHub Bot logged work on BEAM-14306:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/22 13:42
Start Date: 19/Apr/22 13:42
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17370:
URL: https://github.com/apache/beam/pull/17370#discussion_r853092756
##########
sdks/go/pkg/beam/core/graph/coder/panes.go:
##########
@@ -60,11 +64,11 @@ func EncodePane(v typex.PaneInfo, w io.Writer) error {
func NewPane(b byte) typex.PaneInfo {
pn := typex.NoFiringPane()
- if b&0x01 == 1 {
- pn.IsFirst = true
+ if !(b&0x02 == 2) {
+ pn.IsFirst = false
}
- if b&0x02 == 2 {
- pn.IsLast = true
+ if !(b&0x01 == 1) {
+ pn.IsLast = false
Review Comment:
Discussed offline but documenting here: the NoFiringPane's default for
IsFirst and IsLast is true, so when modifying it into the correct pane we we
check for the false case.
Issue Time Tracking
-------------------
Worklog Id: (was: 758472)
Time Spent: 2h 10m (was: 2h)
> Add unit testing to the pane coder
> ----------------------------------
>
> Key: BEAM-14306
> URL: https://issues.apache.org/jira/browse/BEAM-14306
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Add unit testing to the pane code in graph/coder. Coder implementation
> follows the [runner API
> spec|https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto#L922].
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
