[
https://issues.apache.org/jira/browse/BEAM-14306?focusedWorklogId=760515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760515
]
ASF GitHub Bot logged work on BEAM-14306:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/22 00:08
Start Date: 22/Apr/22 00:08
Worklog Time Spent: 10m
Work Description: lostluck commented on PR #17370:
URL: https://github.com/apache/beam/pull/17370#issuecomment-1105871922
The only thing I can think of to improve things is to include hard coded
values for the encoded/decoded panes, (eg the "no firing pane" is `0xf`) etc,
so we aren't relying on the round trip for correctness. (eg. If I say A(B(0))
= 0, all that says is A and B are inverses, but not what they do.)
Issue Time Tracking
-------------------
Worklog Id: (was: 760515)
Time Spent: 2h 50m (was: 2h 40m)
> Add unit testing to the pane coder
> ----------------------------------
>
> Key: BEAM-14306
> URL: https://issues.apache.org/jira/browse/BEAM-14306
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Add unit testing to the pane code in graph/coder. Coder implementation
> follows the [runner API
> spec|https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto#L922].
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
