[
https://issues.apache.org/jira/browse/BEAM-14338?focusedWorklogId=759476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759476
]
ASF GitHub Bot logged work on BEAM-14338:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 18:39
Start Date: 20/Apr/22 18:39
Worklog Time Spent: 10m
Work Description: jrmccluskey opened a new pull request, #17414:
URL: https://github.com/apache/beam/pull/17414
Replaces direct comparisons of time values with Equals calls, avoiding a
mismatch due to location and clock reading also being checked in direct
comparison cases.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 759476)
Remaining Estimate: 0h
Time Spent: 10m
> Use time.Time.Equals() in SDF tests
> -----------------------------------
>
> Key: BEAM-14338
> URL: https://issues.apache.org/jira/browse/BEAM-14338
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Use the time package's equals functionality for time comparisons instead of
> direct comparisons in watermark estimation unit tests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)