[
https://issues.apache.org/jira/browse/BEAM-14338?focusedWorklogId=759513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759513
]
ASF GitHub Bot logged work on BEAM-14338:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 19:32
Start Date: 20/Apr/22 19:32
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17414:
URL: https://github.com/apache/beam/pull/17414#issuecomment-1104379626
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17414?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17414](https://codecov.io/gh/apache/beam/pull/17414?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e90d218) into
[master](https://codecov.io/gh/apache/beam/commit/e4d2050ccbaafb90428ab6c0cc494039f6282dae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e4d2050) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17414 +/- ##
=======================================
Coverage 73.83% 73.83%
=======================================
Files 686 686
Lines 90143 90143
=======================================
Hits 66555 66555
Misses 22406 22406
Partials 1182 1182
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.55% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17414?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17414?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[e4d2050...e90d218](https://codecov.io/gh/apache/beam/pull/17414?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 759513)
Time Spent: 1h 10m (was: 1h)
> Use time.Time.Equals() in SDF tests
> -----------------------------------
>
> Key: BEAM-14338
> URL: https://issues.apache.org/jira/browse/BEAM-14338
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Use the time package's equals functionality for time comparisons instead of
> direct comparisons in watermark estimation unit tests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
