[ 
https://issues.apache.org/jira/browse/BEAM-13984?focusedWorklogId=759668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759668
 ]

ASF GitHub Bot logged work on BEAM-13984:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Apr/22 00:27
            Start Date: 21/Apr/22 00:27
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on code in PR #17196:
URL: https://github.com/apache/beam/pull/17196#discussion_r854670061


##########
sdks/python/setup.py:
##########
@@ -234,6 +234,10 @@ def get_version():
     'azure-core >=1.7.0',
 ]
 
+ML_REQUIREMENTS = [
+    'torch >= 1.10.2'

Review Comment:
   I can't see the original change now, but I think this was in an extra. It 
would be a requirement that's added when you `pip install apache-beam[ml]`, so 
it wouldn't be a hard dependency for all users.
   
   Regardless I think we should hold off adding a requirement spec anywhere, 
unless we need to communicate that there's restricted version range we support. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 759668)
    Time Spent: 3h 40m  (was: 3.5h)

> Implement RunInference for PyTorch
> ----------------------------------
>
>                 Key: BEAM-13984
>                 URL: https://issues.apache.org/jira/browse/BEAM-13984
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Andy Ye
>            Assignee: Andy Ye
>            Priority: P2
>              Labels: run-inference
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Implement RunInference for PyTorch as described in the design doc 
> [https://s.apache.org/inference-sklearn-pytorch]
> There will be a pytorch_impl.py file that contains PyTorchModelLoader and 
> PyTorchInferenceRunner classes.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to