[ 
https://issues.apache.org/jira/browse/BEAM-13984?focusedWorklogId=760330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760330
 ]

ASF GitHub Bot logged work on BEAM-13984:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Apr/22 19:09
            Start Date: 21/Apr/22 19:09
    Worklog Time Spent: 10m 
      Work Description: yeandy commented on code in PR #17196:
URL: https://github.com/apache/beam/pull/17196#discussion_r855515102


##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -85,6 +85,15 @@ toxTask "testPy38pandas-14", "py38-pandas-14"
 test.dependsOn "testPy38pandas-14"
 preCommitPy38.dependsOn "testPy38pandas-14"
 
+// Create a test task for each minor version of pytorch
+toxTask "testPy38pytorch-19", "py38-pytorch-19"
+test.dependsOn "testPy38pytorch-19"
+preCommitPy38.dependsOn "testPy38pytorch-19"
+
+toxTask "testPy38pytorch-110", "py38-pytorch-110"
+test.dependsOn "testPy38pytorch-110"
+preCommitPy38.dependsOn "testPy38pytorch-110"

Review Comment:
   Pytorch has a 90-day release cycle, but it doesn't seem that their changes 
really touch on the APIs that we use. 
   
   Maybe we can test the most recent release (pytorch 1.11.0), along with the 
last minor version of the last X major versions (pytorch 1.10.2, pytorch 1.9.1, 
pytorch 1.8.2, ...). I'll create a ticket to investigate this





Issue Time Tracking
-------------------

    Worklog Id:     (was: 760330)
    Time Spent: 4h 40m  (was: 4.5h)

> Implement RunInference for PyTorch
> ----------------------------------
>
>                 Key: BEAM-13984
>                 URL: https://issues.apache.org/jira/browse/BEAM-13984
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Andy Ye
>            Assignee: Andy Ye
>            Priority: P2
>              Labels: run-inference
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> Implement RunInference for PyTorch as described in the design doc 
> [https://s.apache.org/inference-sklearn-pytorch]
> There will be a pytorch_impl.py file that contains PyTorchModelLoader and 
> PyTorchInferenceRunner classes.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to