[
https://issues.apache.org/jira/browse/BEAM-14358?focusedWorklogId=761073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761073
]
ASF GitHub Bot logged work on BEAM-14358:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/22 19:47
Start Date: 22/Apr/22 19:47
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17449:
URL: https://github.com/apache/beam/pull/17449#discussion_r856525412
##########
sdks/go/test/integration/io/xlang/jdbc/jdbc_test.go:
##########
@@ -68,9 +70,23 @@ func setupTestContainer(t *testing.T, ctx context.Context,
dbname, username, pas
},
Started: true,
}
- container, err := testcontainers.GenericContainer(ctx, req)
- if err != nil {
- t.Fatalf("failed to start container: %s", err)
+
+ strategy := retry.LimitCount(maxRetryCount,
+ retry.Exponential{
+ Initial: time.Second,
+ Factor: 2,
+ },
+ )
+ var container testcontainers.Container
+ var err error
+ for r := retry.Start(strategy, nil); r.Next(); {
+ container, err = testcontainers.GenericContainer(ctx, req)
+ if err == nil {
+ break
+ }
+ if r.Count() == maxRetryCount {
+ t.Fatalf("failed to start container: %v", err)
Review Comment:
```suggestion
t.Fatalf("failed to start container with %v retries:
%v", maxRetryCount, err)
```
Issue Time Tracking
-------------------
Worklog Id: (was: 761073)
Time Spent: 1h 40m (was: 1.5h)
> validatesCrossLanguageRunnerGoUsingJava failing on beam_PostCommit_XVR_Direct
> -----------------------------------------------------------------------------
>
> Key: BEAM-14358
> URL: https://issues.apache.org/jira/browse/BEAM-14358
> Project: Beam
> Issue Type: Bug
> Components: cross-language, sdk-go
> Reporter: Andrew Pilloud
> Assignee: Ritesh Ghorse
> Priority: P1
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This appears to be a flake, but it has failed 5 of the last 6 runs and 12 of
> the last 28. This has been flaking at around 50% of runs for longer than we
> have build history. I suspect https://github.com/apache/beam/pull/16819 is
> responsible.
> begining of history:
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2441/
> (skiped a bunch)
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2474/
> (skiped a bunch)
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2501/
> (skiped a bunch)
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2531/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2534/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2541/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2542/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2545/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2546/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2550/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2554/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2556/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2557/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2558/
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/2559/
--
This message was sent by Atlassian Jira
(v8.20.7#820007)