[
https://issues.apache.org/jira/browse/BEAM-13983?focusedWorklogId=762051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762051
]
ASF GitHub Bot logged work on BEAM-13983:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/22 22:17
Start Date: 25/Apr/22 22:17
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on code in PR #17459:
URL: https://github.com/apache/beam/pull/17459#discussion_r858069139
##########
sdks/python/apache_beam/ml/inference/sklearn_loader.py:
##########
@@ -70,9 +70,11 @@ def load_model(self):
return pickle.load(file)
elif self._model_file_type == ModelFileType.JOBLIB:
if not joblib:
- raise ImportError('Joblib not available in SklearnModelLoader.')
+ raise ImportError('Could not import joblib in this execution'
+ ' environment. https://beam.apache.org/documentation/'
+ 'sdks/python-pipeline-dependencies/')
Review Comment:
nit: I might add a little more context here (I'm fine if you'd rather keep
it as-is though)
```suggestion
raise ImportError('Could not import joblib in this execution'
' environment. For help with managing dependencies on Python
workers see
https://beam.apache.org/documentation/sdks/python-pipeline-dependencies/')
```
Issue Time Tracking
-------------------
Worklog Id: (was: 762051)
Time Spent: 6h 10m (was: 6h)
> Implement RunInference for Scikit-learn
> ---------------------------------------
>
> Key: BEAM-13983
> URL: https://issues.apache.org/jira/browse/BEAM-13983
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Andy Ye
> Assignee: Ryan Thompson
> Priority: P2
> Labels: run-inference
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Implement RunInference for Scikit-learn as described in the design doc
> [https://s.apache.org/inference-sklearn-pytorch]
> There will be a sklearn_impl.py file that contains SklearnModelLoader and
> SlkearnInferenceRunner classes.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
