[
https://issues.apache.org/jira/browse/BEAM-11106?focusedWorklogId=762946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762946
]
ASF GitHub Bot logged work on BEAM-11106:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 15:01
Start Date: 27/Apr/22 15:01
Worklog Time Spent: 10m
Work Description: riteshghorse commented on code in PR #17432:
URL: https://github.com/apache/beam/pull/17432#discussion_r859911593
##########
sdks/go/pkg/beam/core/graph/fn.go:
##########
@@ -847,9 +886,15 @@ func validateSdfSigNumbers(fn *Fn, num int) error {
func validateSdfSigTypes(fn *Fn, num int) error {
restrictionT := fn.methods[createInitialRestrictionName].Ret[0].T
rTrackerT := reflect.TypeOf((*sdf.RTracker)(nil)).Elem()
-
- for _, name := range requiredSdfNames {
- method := fn.methods[name]
+ bRTrackerT := fn.methods[createTrackerName].Ret[0].T
+ optionalSdfs := optionalSdfNameMap()
+
+ for _, name := range sdfNames {
+ method, ok := fn.methods[name]
+ if !ok && optionalSdfs[name] {
+ // skip validating unimplemented optional sdf methodsß
+ continue
+ }
Review Comment:
Yeah, optional sdf functions should be validated but only when they are
implemented by users. Otherwise, we should skip its validation.
Issue Time Tracking
-------------------
Worklog Id: (was: 762946)
Time Spent: 2h 20m (was: 2h 10m)
> [Go SDK] Truncating SDFs during drain
> -------------------------------------
>
> Key: BEAM-11106
> URL: https://issues.apache.org/jira/browse/BEAM-11106
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Ritesh Ghorse
> Priority: P3
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Allow SDFs to specify a restriction truncation method to permit faster drains.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
