[ 
https://issues.apache.org/jira/browse/BEAM-11106?focusedWorklogId=765725&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765725
 ]

ASF GitHub Bot logged work on BEAM-11106:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/May/22 22:27
            Start Date: 03/May/22 22:27
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on code in PR #17432:
URL: https://github.com/apache/beam/pull/17432#discussion_r864303864


##########
sdks/go/pkg/beam/core/sdf/lock.go:
##########
@@ -80,3 +80,15 @@ func (rt *LockRTracker) GetRestriction() interface{} {
        defer rt.Mu.Unlock()
        return rt.Rt.GetRestriction()
 }
+
+// IsBounded locks a mutex for thread safety, and then delegates to the
+// underlying tracker's IsBounded(). If BoundableRTracker is not implemented
+// then the RTracker is considered to be bounded by default.
+func IsBounded(rt *LockRTracker) bool {

Review Comment:
   Why is this an unused function instead of a method on *LockRTracker?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 765725)
    Time Spent: 3h 50m  (was: 3h 40m)

> [Go SDK] Truncating SDFs during drain
> -------------------------------------
>
>                 Key: BEAM-11106
>                 URL: https://issues.apache.org/jira/browse/BEAM-11106
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Ritesh Ghorse
>            Priority: P3
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> Allow SDFs to specify a restriction truncation method to permit faster drains.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and 
> the programming guide updated with SDF content.)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to